Skip to content

Add Iceberg REST auth server configuration property#23739

Merged
kiersten-stokes merged 1 commit intoprestodb:masterfrom
kiersten-stokes:add-auth-server
Oct 1, 2024
Merged

Add Iceberg REST auth server configuration property#23739
kiersten-stokes merged 1 commit intoprestodb:masterfrom
kiersten-stokes:add-auth-server

Conversation

@kiersten-stokes
Copy link
Copy Markdown
Contributor

@kiersten-stokes kiersten-stokes commented Sep 27, 2024 •
edited
Loading

Description

This PR adds a new configuration property for an OAUTH2 server uri: iceberg.rest.auth.oauth2.uri

Motivation and Context

Fixes #23491

See linked issue for context

Impact

Adds a iceberg.rest.auth.oauth2.uri configurable property

Test Plan

Configuration tests have been updated

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Iceberg Connector Changes
* Add iceberg.rest.auth.oauth2.uri configurable property :pr:`23739`

steveburnett
steveburnett previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good. Thanks!

agrawalreetika
agrawalreetika previously approved these changes Sep 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@agrawalreetika agrawalreetika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZacBlanco
ZacBlanco reviewed Sep 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ZacBlanco ZacBlanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to see a unit test where we can verify the catalog config has properly set the OAUTH2_SERVER_URI as well.

@kiersten-stokes kiersten-stokes merged commit 266ccec into prestodb:master Oct 1, 2024
@c-thiel c-thiel mentioned this pull request Oct 1, 2024
Closed
@jaystarshot jaystarshot mentioned this pull request Nov 1, 2024
Merged
25 tasks
@tdcmeehan tdcmeehan added the from:IBM PR from IBM label Dec 13, 2024
@prestodb-ci prestodb-ci requested review from a team, ScrapCodes and aaneja and removed request for a team December 13, 2024 15:31
@prestodb-ci
Copy link
Copy Markdown
Contributor

prestodb-ci commented Dec 13, 2024

Saved that user @kiersten-stokes is from IBM

@steveburnett
Copy link
Copy Markdown
Contributor

steveburnett commented Jan 6, 2025

Formatting nit for the release note entry

== RELEASE NOTES ==

Iceberg Connector Changes
* Add ``iceberg.rest.auth.oauth2.uri`` configurable property. :pr:`23739`

steveburnett
steveburnett reviewed Jan 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steveburnett steveburnett steveburnett left review comments

@ZacBlanco ZacBlanco ZacBlanco approved these changes

@agrawalreetika agrawalreetika agrawalreetika approved these changes

@hantangwangd hantangwangd hantangwangd approved these changes

@elharo elharo Awaiting requested review from elharo elharo is a code owner

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

@ScrapCodes ScrapCodes Awaiting requested review from ScrapCodes ScrapCodes was automatically assigned from prestodb/ibm-reviewers

@aaneja aaneja Awaiting requested review from aaneja aaneja was automatically assigned from prestodb/ibm-reviewers

Assignees

No one assigned

Labels

from:IBM PR from IBM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Iceberg REST configurable OAuth Endpoint

7 participants

@kiersten-stokes @prestodb-ci @steveburnett @ZacBlanco @agrawalreetika @hantangwangd @tdcmeehan